Delete threads with no replies #6578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the deletion of threads that have no replies while reassigning threads that do have replies to the sumo bot. Key changes include:
- Updating tests in both forums and kbforums to verify that threads with no replies are deleted and threads with replies are reassigned.
- Modifying ThreadListener and PostListener in both forums and kbforums to reflect the new deletion and reassignment logic.
- Adjusting test data creation to include a replies count for threads.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| kitsune/forums/tests/test_handlers.py | Added tests for empty thread deletion and updated post creation in threads. |
| kitsune/kbforums/tests/test_handlers.py | Updated thread creation to include replies count and added empty thread deletion tests. |
| kitsune/kbforums/handlers.py | Changed ThreadListener to reassign threads with replies and delete others. |
| kitsune/forums/handlers.py | Updated ThreadListener and PostListener to perform reassignment and thread deletion. |
Comments suppressed due to low confidence (1)
kitsune/forums/handlers.py:19
- Consider explicitly filtering for empty threads (e.g., using 'replies=0') when deleting threads. This change would improve code clarity and reduce any risk if the update to reassign threads does not take effect as expected.
threads_to_delete.delete()
Comment on lines
+13
to
14
| Thread.objects.filter(creator=user).delete() | ||
|
|
There was a problem hiding this comment.
Consider explicitly filtering for threads with no replies (e.g., adding 'replies=0') during deletion to ensure that only threads with no replies are removed.
Suggested change
| Thread.objects.filter(creator=user).delete() | |
| Thread.objects.filter(creator=user, replies=0).delete() |
Copilot uses AI. Check for mistakes.
escattone
approved these changes
Mar 20, 2025
kitsune/forums/handlers.py
Outdated
Comment on lines
18
to
19
| threads_to_reassign.update(creator=Profile.get_sumo_bot()) | ||
| threads_to_delete.delete() |
There was a problem hiding this comment.
Super nit. I think it would be easier to read/understand with the variables replaced with their actual queries like you do within the KB forums handler.
23688a1 to
ce74442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.